- 
                Notifications
    You must be signed in to change notification settings 
- Fork 119
Refactor lattice flipping for modes #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    riaqn
  
              
              commented
              
                  
                    May 2, 2025 
                  
              
              
            
            
              
                    riaqn
  
              
              commented
              
                  
                    May 2, 2025 
                  
              
              
            
            
9f251f0    to
    7260beb      
    Compare
  
    
              
                    goldfirere
  
              
              approved these changes
              
                  
                    May 21, 2025 
                  
              
              
            
            
    
  Gbury 
      pushed a commit
        to Gbury/flambda-backend
      that referenced
      this pull request
    
      May 27, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Currently in
solver.mlthere isSolver_monowhich can handle monotone morphisms. Based on that, there are two polarized solversPositiveandNegative, used for comonadic and monadic axes respectively. The intention is such that user code (mode.ml) doesn't need to think about the flipping. This has two issues:mode.mlstill needs to think about the flipping in some definitions but not all of them. This mixture, and the fact that bothmode.mlandsolver.mlhandles flipping, makes the code more confusing.Positive.tandNegative.tare different types and complicates type polymorphism. In particular,Value.Axis.tis a complicated GADT.So we remove both
PositiveandNegative, and letmode.mlto be the only file that cares about flipping. We move some code such that the flipping are concentrated to fewer places.The downside is that code that uses
modemight see(Uniqueness.Const.t, allowed * disallowed) modeinstead of(disallowed * allowed) Uniqueness.t. The two types are the same, but ideally we want to show the latter.Review
Please review by commit.